[Bug 451744] Review Request: root - The CERN analyzer for high to medium energy physics

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: root - The CERN analyzer for high to medium energy physics


https://bugzilla.redhat.com/show_bug.cgi?id=451744





------- Additional Comments From pertusus at free.fr  2008-06-29 05:36 EST -------
Missing buildRequires, at least:

libGL-devel libGLU-devel
postgresql-devel mysql-devel
krb5-devel
fftw-devel
python-devel
qt4-devel
ftgl-devel
gcc-gfortran
python-devel

Some may not really needed because they are in turn dependencies of
other BuildRequires.

The internal libAfterImage is used, there is this:
WARNING: System libAfterImage is too new, using built-in
this should be fixed. A libafterimage library is shipped which is
clearly wrong.

Also there is a minicern library, instead the system cern library, in
cernlib-utils
should be used. Then the 2 apps depending on the cernlib could be 
in a separate package.

It would be nice if you could remove the in-source 3rd party library
directories before doing the build, to be sure that they are not used.

There are 2 files installed not packaged:
   /usr/bin/g2root
   /usr/bin/h2root

The libraries should have a soname, you should add --enable-soversion

Currently the programs don't start because the shared libraries are not found 
by the dynamic loader. To correct that you should add a file in /etc/ld.so.conf.d

The fedora build flags are not used.

Some binary names are too generic in my opinion, namely:
root, roots, genmap, xrd

How is the python ROOT module used? Shouldn't it be in the python 
directories? And similar with genreflex. And there is also a 
/usr/lib/root/writer.py
which looks dubious. How is it used? In any case it should certainly be 
below %_datadir (or in the python dirs).

A separate package should be done for the (x)emacs stuff, there are
guidelines for that.

Many files and directories that are in %_sysconfdir doesn't look 
like configuration, like 
/etc/root/html/
/etc/root/RadioNuclides.txt
/etc/root/gdb-backtrace.sh
/etc/root/valgrind-root.supp 
/etc/root/root.mimes
/etc/root/proof/

Most should certainly be in %_datadir

Is 
/etc/root/vmc/
really needed? If needed it certainly should be in %_datadir and in -devel.

Are the files in 
/usr/share/root/plugins/
used at runtime? (they are in root-devel)

According to the doc, it seems that the files in /etc/profile.d are
not needed.

root-config may also be useful at runtime to have programs find the 
paths/arch, at least it is used in root.sh (though it is not useful for
linux).

I am not sure that the root icons should be in 
/usr/share/icons/
this directory is for icon themes conforming with freedesktop.
It should certainly better be in /usr/share/root/icons

At least a .desktop file is missing for root, and maybe more.

What is the difference between root and root.exe?

in the root.mime file, external applications should use xdg-open.

Because of the loader issue above I cannot test, but I'd like to
have an example showing when the cint header files are needed.

In the init.d files, you should remove references to environment variables.
in  the xrootd there is a @libdir@, but in fact all that relates to
LD_LIBRARY_PATH should be removed. Also there should be example
/etc/sysconfig/*d to show even in a very sketchy way what can go in these
files. It even seems to me than some variales should be mandatorily 
set in these sysconfig files, like XRDUSER. Corresponding users should
be created, there is a related guideline for user and group creation.

Looks like there are many things done in /tmp, it would be nice to be sure
that what is done here is always done with unpredictable names, to avoid
the race in tmp security issue.

There are many dependencies that are not in fedora (like pythia, castor,
globus...) some of which may be free software other aren't. In general I insist
on having all the free software dependencies in fedora, but in that case
this  means really too much. There is one dep already in fedora, unuran, you 
could try to use it.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.