[Bug 450616] opensm package

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: opensm package


https://bugzilla.redhat.com/show_bug.cgi?id=450616


ed at eh3.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |ed at eh3.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From ed at eh3.com  2008-06-29 13:08 EST -------
Hi Doug, thank you for submitting an opensm package for Fedora.  Here is a 
quick review:

GOOD:
+ source matches upstream:
    f2f47a9bad4ba3ed1c48361dfc8f21826882b7cb  opensm-3.2.1.tar.gz
    f2f47a9bad4ba3ed1c48361dfc8f21826882b7cb  opensm-3.2.1.tar.gz.UP
+ license is correct and correctly included
+ permissions look good
+ dir ownership looks good
+ with dependencies installed, local builds on F8 x86_64 succeed
+ rpmlint reports:
opensm.src: W: strange-permission opensm.initd 0775
opensm.x86_64: W: non-conffile-in-etc /etc/logrotate.d/opensm
opensm.x86_64: E: binary-or-shlib-defines-rpath /usr/sbin/osmtest
['/usr/lib64',
'/u/u0/ehill/rpmbuild/BUILD/opensm-3.2.1/osmtest/../../libibumad/.libs',
'/u/u0/ehill/rpmbuild/BUILD/opensm-3.2.1/osmtest/../../libibcommon/.libs']
opensm.x86_64: E: binary-or-shlib-defines-rpath /usr/sbin/opensm
['/usr/lib64',
'/u/u0/ehill/rpmbuild/BUILD/opensm-3.2.1/opensm/../../libibumad/.libs',
'/u/u0/ehill/rpmbuild/BUILD/opensm-3.2.1/opensm/../../libibcommon/.libs']
opensm.x86_64: W: dangerous-command-in-%preun rm
opensm.x86_64: E: malformed-line-in-lsb-comment-block #
opensm-devel.x86_64: W: no-documentation
opensm-libs.x86_64: W: no-documentation
opensm-libs.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/libosmvendor.so.2.0.0 ['/usr/lib64']
opensm-libs.x86_64: W: one-line-command-in-%post /sbin/ldconfig
opensm-libs.x86_64: W: one-line-command-in-%postun /sbin/ldconfig
opensm-static.x86_64: W: no-documentation


NEEDSWORK:
+ First, the rpath issues.  I've tried to put together a patch that removes
  the rpaths from the configure script and some of the Makefile.in-s but so
  far I've failed to remove all of them.  And, removing some of the rpaths
  breaks the install since certain *.la{i,} files won't get generated.  
  Perhaps someone with stronger hack-fu can (please?) take a look at it?
  Or, perhaps we can just ignore these rather-annoying rpath warnings
  since it is something specific to just these two opensm executables (and
  cannot cause any std-path problems for other packages since they are not 
  shared libs).
+ Please delete the blank line in the LSB comment block.
+ Please use '%post libs -p /sbin/ldconfig' and
  '%postun libs -p /sbin/ldconfig'

I haven't (yet) had the time to install and run it on a machine with 
IB hardware -- will try that next.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.