[Bug 394871] Review Request: automaton - a Java finite state automata/regular expression library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: automaton - a Java finite state automata/regular expression library


https://bugzilla.redhat.com/show_bug.cgi?id=394871


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From tibbs at math.uh.edu  2008-06-29 16:08 EST -------
Looks like mona also went with the X.YrZ version format as well, which is fine
with me.

rpmlint complains only about the Group: tags, which seems to be normal for java
packages and which we don't care about anyway.

I'm pretty sure the jars are rebuilt, but the upstream source includes a
prebuilt one, so it would be best to simply delete it in %prep.

The gcj bits should all be conditionalized.

* source files match upstream:
   2af431a4c9beee99d9739d1284efa99a4b21c6bfd27059f430de6ef4574cdb56  
   automaton-1.10-4.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
  automaton-1.10r4-1.fc10.x86_64.rpm
   automaton-1.10r4.jar.so()(64bit)
   automaton = 1.10r4-1.fc10
  =
   /bin/sh
   java
   java-gcj-compat >= 1.0.31
   jpackage-utils
   libgcc_s.so.1()(64bit)
   libgcc_s.so.1(GCC_3.0)(64bit)
   libgcj_bc.so.1()(64bit)
   libz.so.1()(64bit)

  automaton-javadoc-1.10r4-1.fc10.x86_64.rpm
   automaton-javadoc = 1.10r4-1.fc10
  =
   automaton = 1.10r4-1.fc10
   jpackage-utils

* %check is not present; no test suite upstream.  I to not know how to test this 
   package.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
X scriptlets should consitionalize the gcj bits.
* code, not content.
* %docs are not necessary for the proper functioning of the package.
? no pre-built jars
* single jar, named after the package
* jarfiles are under _javadir.
* javadocs are under _javadocdir.
* ant called properly.
* no wrapper script necessary.
X gcj not called properly; should be conditionalized.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.