[Bug 449869] Review Request: tasque - A simple task management app

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tasque - A simple task management app


https://bugzilla.redhat.com/show_bug.cgi?id=449869


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-06-29 16:32 EST -------
Some random comments on 0.1.5-1:

* Version
  - Current newest tarball seems 0.1.6.

* tarball
  - As the upstream ships bzip2 compressed tarball, please use it.

* BuildRequires:
  - Currently mono-core is not available on ppc64. So
    this package needs 'ExcludeArch: ppc64'.

* Timestamps
  - To keep timestamps on installed files, please consider to use:
------------------------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
------------------------------------------------------------------
    This method usually works for recent autotool based Makefiles.

* Installed directory
  - Currently this package installs somefiles under %{_prefix}/lib/%{name},
    which is wrong for 64 bits machine (x86_64, where %{_prefix}/lib
    is /usr/lib while %{_libdir} is /usr/lib64).
    Please apply a patch so that this package use %{_libdir}/%{name}

* Directory ownership issue
  - Please make it sure that all directories created when installing
    this package are owned correctly by this package.
    Currently %{_libdir}/%{name}, %{_datadir}/%{name} are not owned by
    any packages.

* GTK icon cache update
  - As this package installs icons under %_datadir/icons/hicolor, please
    follow
    https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GTK.2B_icon_cache

* defattr
  - Please unify defattr usage to %defattr(-,root,root,-)

* Requires
  - It seems that this package needs some Requires:
    On my system:
---------------------------------------------------------------
[tasaka1 at localhost ~]$ tasque 

** (Tasque.exe:5510): WARNING **: The following assembly referenced from
/usr/lib/tasque/Tasque.exe could not be loaded:
     Assembly:   gnome-sharp    (assemblyref_index=2)
     Version:    2.16.0.0
     Public Key: 35e10195dab3c99f
The assembly was not found in the Global Assembly Cache, a path listed in the
MONO_PATH environment variable, or in the location of the executing assembly
(/usr/lib/tasque/).


** (Tasque.exe:5510): WARNING **: Could not load file or assembly 'gnome-sharp,
Version=2.16.0.0, Culture=neutral, PublicKeyToken=35e10195dab3c99f' or one of
its dependencies.

Unhandled Exception: System.TypeLoadException: Could not load type
'Tasque.Application' from assembly 'Tasque, Version=0.0.0.0, Culture=neutral'.
---------------------------------------------------------------

Please make it sure that you change the release number of the spec file every time
you modify your spec file when version number does not change.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.