[Bug 450816] Review Request: alevt - Teletext decoder/browser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: alevt - Teletext decoder/browser


https://bugzilla.redhat.com/show_bug.cgi?id=450816





------- Additional Comments From mnowak at redhat.com  2008-06-30 04:41 EST -------
Proposing this patch, which is more fedora best practices aware:

* still populates the OPT variable but without invoking %configure (which fails
right after)
* less variable playing/messing 
* updated comment


--- alevt.spec  2008-06-29 19:26:04.000000000 +0200
+++ alevt.spec_new      2008-06-30 10:36:39.000000000 +0200
@@ -23,14 +23,11 @@ This program decodes and displays Videot
 %build
 #overwrite $OPT to produce standard Fedora build with propper FLAGS
 
-# alevt does not have standard build system, so we call configure
-# to populate CFLAGS, then we move them to another var which persists
-# and we *unset CFLAGS* and have alevt build system to populate it
-%configure || true
-FLAGS=${CFLAGS}
-unset CFLAGS
+# alevt does not have standard build system, so we populate OPT, 
+# which is internal build variable to accomodate Fedora opt flags
+
 # will produce lot of garbage on output
-make %{?_smp_mflags} -e OPT="${FLAGS}"
+make %{?_smp_mflags} -e OPT="%{optflags}"
 
 
 %install


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.