[Bug 453224] Review Request: prelude-correlator - Correlates IDMEF events for prelude-manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: prelude-correlator - Correlates IDMEF events for prelude-manager


https://bugzilla.redhat.com/show_bug.cgi?id=453224





------- Additional Comments From tmraz at redhat.com  2008-06-30 07:54 EST -------
First comments:
Please add some meaningful text to the Summary of the main package. Something
like "Real time correlator of events received by Prelude Manager"

The version/release must match the upstream and comply with the Fedora
NamingGuidelines (the beta1b should be added to the release). version should be:
0.9.0 and release: 0.1.beta1b (0.2.beta1b, ....)

rpmlint -v prelude-correlator-0.9.0-1.fc9.x86_64.rpm
prelude-correlator.x86_64: I: checking
prelude-correlator.x86_64: E: non-standard-dir-perm
/etc/prelude-correlator/lua-rules 0700
prelude-correlator.x86_64: E: non-standard-dir-perm /etc/prelude-correlator 0700
Do these directories have to be unreadable to group/other? 

prelude-correlator.x86_64: E: zero-length
/usr/share/doc/prelude-correlator-0.9.0/AUTHORS
Please drop AUTHORS from docs if it is empty.

prelude-correlator.x86_64: W: incoherent-version-in-changelog 0.9.0.beta1b
0.9.0-1.fc9
See above.

prelude-correlator.x86_64: W: incoherent-subsys
/etc/rc.d/init.d/prelude-correlator $prog
This is OK.

rpmlint -v prelude-correlator-devel-0.9.0-1.fc9.x86_64.rpm 
prelude-correlator-devel.x86_64: I: checking
prelude-correlator-devel.x86_64: W: no-documentation

rpmlint -v prelude-correlator-debuginfo-0.9.0-1.fc9.x86_64.rpm 
prelude-correlator-debuginfo.x86_64: I: checking

rpmlint -v prelude-correlator-0.9.0-1.fc9.src.rpm 
prelude-correlator.src: I: checking
prelude-correlator.src: W: mixed-use-of-spaces-and-tabs (spaces: line 20, tab:
line 74)
I think this is purely cosmetic and OK.

prelude-correlator.src: W: strange-permission prelude-correlator.init 0755
This is OK.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.