[Bug 435542] Review Request: xdemorse - GTK based application for decoding and displaying Morse code signals

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xdemorse - GTK based application for decoding and displaying Morse code signals


https://bugzilla.redhat.com/show_bug.cgi?id=435542





------- Additional Comments From dan at danny.cz  2008-03-01 06:44 EST -------
some notes
 - you should add the doc/xdemorse.html as %doc too (README and ChangeLog are
referring to it)
 - you should ask upstream to include the license text into ythe source archive
 - when trying to run xdemorse, I am getting an error "Failed to open xdemorserc
file. Quit xdemorse and correct"


Formal review:

OK	source files match upstream:
		c42e15d6056ac7aa3ab8981c9e689ed43770205b  xdemorse-0.9.tar.gz
OK	package meets naming and versioning guidelines.
OK	specfile is properly named, is cleanly written and uses macros consistently.
OK	dist tag is present.
OK	build root is correct.
OK	license field matches the actual license.
OK	license is open source-compatible (GPLv2+). License text not included upstream.
OK	latest version is being packaged.
OK	BuildRequires are proper.
OK	compiler flags are appropriate.
OK	%clean is present.
OK	package builds in mock (F-8/x86_64, Rawhide/x86_64).
OK	debuginfo package looks complete.
OK	rpmlint is silent.
OK	final provides and requires look sane.
OK	no shared libraries are added to the regular linker search paths.
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK	file permissions are appropriate.
OK	no scriptlets present.
OK	code, not content.
OK	documentation is small, so no -docs subpackage is necessary.
OK	%docs are not necessary for the proper functioning of the package.
OK	no headers.
OK	no pkgconfig files.
OK	no libtool .la droppings.
OK	is a GUI app, desktop file included

So before final approval I need from you to update the %doc with the manual and
fix (or explain) the xdemorserc issue.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.