[Bug 434703] Review Request: ocaml-sqlite - OCaml library for accessing SQLite3 databases

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-sqlite - OCaml library for accessing SQLite3 databases


https://bugzilla.redhat.com/show_bug.cgi?id=434703


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2008-03-01 08:49 EST -------
Review:
+ package builds in mock (rawhide i386).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=481863
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
473b2dea5684dc681c0e3e7ecb083cee  ocaml-sqlite3-0.23.0.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ Compiler flags are honored correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.
+ Package ocaml-sqlite-0.23.0-2.fc9 =>
  Provides: dllsqlite3_stubs.so ocaml(Sqlite3) = c3f364a0311d687e52a8adbeed19f8e5
  Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3)
libsqlite3.so.0 ocaml(Array) = aa8e3cd5824f9bb40b93fcd38d0c95b5 ocaml(Buffer) =
f6cef633ea14963b84b79c4095c63dc3 ocaml(Callback) =
e5ca1fb5990fac2b7b17cbb1712cffe2 ocaml(Obj) = 5cfae708052c692ea39d23ed930fd64d
ocaml(Pervasives) = 8ba3d1faa24d659525c9025f41fd0c57 ocaml(Printf) =
5dbbf45a03b54e6dbfcf39178d0d6341 ocaml(String) =
2c162ab314b2f0a2cfd22d471b2e21ab ocaml(runtime) = 3.10.1
+ Package ocaml-sqlite-devel-0.23.0-2.fc9 =>
  Requires: ocaml-sqlite = 0.23.0-2.fc9
+ Followed ocaml packaging guidelines.
APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.