[Bug 435234] Review Request: xdx - DX-cluster tcp/ip client for amateur radio

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xdx - DX-cluster tcp/ip client for amateur radio


https://bugzilla.redhat.com/show_bug.cgi?id=435234


kanarip at kanarip.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From kanarip at kanarip.com  2008-03-02 09:55 EST -------
RPM Lint: OK
Package name: OK
Spec file: OK
License: OK (GPLv2+)
Actual License: OK (GPLv2+ from source)
%doc License: OK
Spec file language: OK
Spec file readable: OK
Upstream source vs. used tarball: OK (md5sum match)
Compile and Build:
 - F-7: FAILED (not targeted)
 - F-8: OK
 - rawhide: OK
 - EL-5: FAILED (not targeted)

Applicable Package Guidelines:
 - -debuginfo package: OK (~136K)
Locales: OK
Shared libs: N/A
Relocatable: N/A
Directory and file ownership: OK
No duplicate files in %files: OK
File Permissions: OK
Macro usage: OK
Code vs. Content: OK
(Large) Documentation: N/A, OK
%doc affecting runtime: OK
Header files in -devel package: N/A
Static Libraries in -static package: N/A
pkgconfig Requires: OK
Library files: N/A
Devel requires base package: N/A
.la libtool archives: N/A
Duplicate ownership of files/directories: OK
Remove BuildRoot: OK
UTF-8 filenames: OK

In the spec file you have:

#don't include backup file in package
rm -f `find $RPM_BUILD_ROOT -name *~`

which might result in a 'argument list too long' at some point, especially
larger packages. Consider using:

find $RPM_BUILD_ROOT -name "*~" -exec rm -f {} \;

Quoting the -name "*~" ensures it doesn't match against a file in $CWD

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.