[Bug 431098] Review Request: gambas2 - IDE based on a basic interpreter with object extensions

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gambas2 - IDE based on a basic interpreter with object extensions


https://bugzilla.redhat.com/show_bug.cgi?id=431098





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-03-02 12:44 EST -------
Created an attachment (id=296517)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=296517&action=view)
rpmlint for gambase

For 2.2.1-2:

* rpmlint
  - First of all, would would shut up rpmlint warnings/errors
    as much as possible? (rpmlint results attached)

* Duplicate file entry
---------------------------------------------------------
[tasaka1 at localhost gambas2]$ rpm -qlp *i386*rpm | sort | uniq -d
/usr/bin/gambas2
/usr/bin/gambas2.gambas
/usr/share/mime/packages
---------------------------------------------------------
  - Please resolve this.

* Compilation flags
---------------------------------------------------------
  5700	make[4]: Entering directory
`/builddir/build/BUILD/gambas2-2.2.1/main/gbx'
  5701	/bin/sh ../libtool --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.
-I.. -I../share    -I../libltdl  -I/usr/lib/libffi-3.0.1/include   -DGBX_INFO
-O2 -g -pipe -Wall  -fexceptions -fstack-protector --param=ssp-buffer-size=4
-m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -pipe -Wall
-Wno-unused-value -fvisibility=hidden -g -Os -O0  -MT gb_la-gbx_c_class.lo -MD
-MP -MF .deps/gb_la-gbx_c_class.Tpo -c -o gb_la-gbx_c_class.lo `test -f
'gbx_c_class.c' || echo './'`gbx_c_class.c
---------------------------------------------------------
  - -O2 option is finally replaced by -O0.

---------------------------------------------------------
  6430	make[4]: Entering directory
`/builddir/build/BUILD/gambas2-2.2.1/gb.db.sqlite3/src'
  6431	/bin/sh ../libtool --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I.
-I..	-pipe -Wall -fno-exceptions -Wno-unused-value -fvisibility=hidden -g
-Os -fno-omit-frame-pointer  -MT main.lo -MD -MP -MF .deps/main.Tpo -c -o
main.lo main.cpp
  ( and many lines below this line )
----------------------------------------------------------
  - Here Fedora specific compilation flags are ignored.

* Timestamps
  - I guess for this package
----------------------------------------------------------
make DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" install
----------------------------------------------------------
    works to keep timestamps on installed files.

  - When using "install" or "cp" commands, please add "-p" option
    to keep timestamps.

* Directory ownership issue
  - From my directory ownership check,
----------------------------------------------------------
Owned by			      directory
shared-mime-info-0.23-3.fc9	      /usr/share/mime/packages
gambas2-runtime-2.2.1-2.fc9
gambas2-script-2.2.1-2.fc9
----------------------------------------------------------

* Macros
  - Use macros correctly. For example, /usr/bin must be %{_bindir}.

* Scriptlet
  - Calling update-desktop-database is not needed because
    fedora-gambas2.desktop does not contain any MimeType key.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.