[Bug 433892] Review Request: xfce4-gsynaptics-mcs-plugin - GSynaptics icon for the Xfce Settings Manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfce4-gsynaptics-mcs-plugin - GSynaptics icon for the Xfce Settings Manager


https://bugzilla.redhat.com/show_bug.cgi?id=433892


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From kevin at tummy.com  2008-03-02 13:26 EST -------

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPLv2)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
57ecdd4983ab55614019d4b5a581398e  gsynaptics-mcs-plugin-1.0.0.tar.bz2
57ecdd4983ab55614019d4b5a581398e  gsynaptics-mcs-plugin-1.0.0.tar.bz2.spec
OK - BuildRequires correct
OK - Spec handles locales/find_lang
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output. 
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have dist tag
OK - Should package latest version

Issues:

1. rpmlint says:

xfce4-gsynaptics-mcs-plugin-debuginfo.x86_64: E: description-line-too-long This
package provides debug information for package xfce4-gsynaptics-mcs-plugin.

Just due to the length of package name I guess. Ignore.

No other issues that I see here, so this package is APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.