[Bug 435661] Review Request: Midori - A lightweight GTK+ web browser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Midori - A lightweight GTK+ web browser
Alias: midori

https://bugzilla.redhat.com/show_bug.cgi?id=435661





------- Additional Comments From gnomeuser at gmail.com  2008-03-03 05:14 EST -------
=== GOOD ===
+ Package naming/version is OK. Spec file is appropriately named ("%{name}.spec").
+ License (LGPLv2+) is acceptable for Fedora and matches that of the code.
+ Final file and directory ownership is OK, with no duplicates and appropriate
%defattr lines.
+ BuildRoot is OK, and is properly removed as the first step in %install and as
the only step in %clean.
+ Final requires/provides are sane.
+ Summary and %description are good. The spec is legible and written in American
English.
+ File encodings are OK.
+ Compiler flags are honored; and parallel make is used.
+ No static libraries or libtool archives present.
+ Binaries contain no RPATH kludges.
+ Macro usage is consistent.
+ Timestamps look OK.
+ Package does not seem to conflict with other Fedora stuff.
+ License is included in the package (COPYING).
+ Sources match those of upstream:
  58d1b7ed282540030eb1b5803b760865  ../SOURCES/midori-0.0.17.tar.gz
  58d1b7ed282540030eb1b5803b760865  ../COMPARE/midori-0.0.17.tar.gz
+ Package contains permissible code.
+ Documentation (%doc) does not affect runtime of the program.
+ All filenames are valid UTF-8 
+ Correct .desktop file handling 

=== BAD ===
Rpmlint complaints:
midori.src: W: mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 3)
(actually rpmlint is wrong you have spurious space use in lines: 14, 17, 18
twice, 20, 54 twice and 55)

midori-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/midori-0.0.17/src/main.c

Missing br for desktop-file-utils

=== N/A ==
* Scriplets are OK, including user/group creation in %pre and /sbin/ldconfig
invocations on %post/%postun for the installed shared libraries.
* Header files, pkgconfig data, and unversioned library symlinkes are in a
-devel subpackage as required. It has proper dependencies on the main package
and pkgconfig.
* Locale files handled appropriately (via %find_lang).
* Package is not relocatable.
* No large documentation; no -doc subpackage is necessary.

As an application midori isn't terribly stable, I can crash it in a minute or
so, but hey it's a beta.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.