[Bug 435064] Review Request: midisport-firmware - firmware files for M-Audio/Midiman USB MIDI and Audio devices

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: midisport-firmware - firmware files for M-Audio/Midiman USB MIDI and Audio devices


https://bugzilla.redhat.com/show_bug.cgi?id=435064





------- Additional Comments From lkundrak at redhat.com  2008-03-03 14:13 EST -------
  3 Release:        1

It is fine that this doesn't contain dist tag as this package doesn't ship any
executable and is release independent. (Just a note to me and other reviewers
who may eventually look at this.)

  6 License:        GPL

This is no longer valid, it needs the version specification, e.g. GPL+, GPLv2 or
GPLv3+

According to LICENSE file this is GPLv2+

 18 %setup -q -c

No need for -c, tarball actually contains midisport-firmware-1.2 directory

 26 install -pm 0644 *.{fw,mpg} $RPM_BUILD_ROOT/lib/firmware

This is not correct, this package has not *.fw or *.mpg files. Did you mean
*.ihx? It doesn't build due to this. I'll continue the review once it builds.

 28 # Install the license with the firmware
 29 mv LICENSE license-midisport.txt

What was the reason for installing license in /lib/firmware? It should be
included in %doc instead. Forthermore, please add README to %doc (and probably
also ChangeLog).

 31 install -pm 0644 81-midisport.rules $RPM_BUILD_ROOT/etc/udev/rules.d/
...
 46 /etc/udev/rules.d/81-midisport.rules

Please replace occurences of /etc with %{_sysconfdir}

 49 * Thu Feb 28 2008 Dave Jones <davej at redhat.com>

Please include - version-release (sans disttag, " - 1.2-1" in this case) at the
end of changelog header

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.