[Bug 434691] Review Request: ocaml-postgresql - OCaml library for accessing PostreSQL databases

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-postgresql - OCaml library for accessing PostreSQL databases


https://bugzilla.redhat.com/show_bug.cgi?id=434691





------- Additional Comments From panemade at gmail.com  2008-03-03 22:35 EST -------
Review:
+ package builds in mock (rawhide i386).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=489172
+ rpmlint is NOT silent for SRPM and for RPM.
ocaml-postgresql.i386: W: invalid-license LGPLv2+ with exceptions
ocaml-postgresql.src: W: invalid-license LGPLv2+ with exceptions
ocaml-postgresql-devel.i386: W: invalid-license LGPLv2+ with exceptions
==> Ok to accept as per fixed in bug 434690
+ source files match upstream.
c79dbef491646610cfb22559e0fc2c16  postgresql-ocaml-1.7.0.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ Compiler flags are honored correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no .pc file present.
+ -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.
+ Package ocaml-postgresql-1.7.0-2.fc9 =>
 Provides: dllpostgresql_stubs.so ocaml(Postgresql) =
5e9f1f2c527e4b7c59632902b765f8d3
  Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libpq.so.5
ocaml(Array) = aa8e3cd5824f9bb40b93fcd38d0c95b5 ocaml(Buffer) =
f6cef633ea14963b84b79c4095c63dc3 ocaml(Callback) =
e5ca1fb5990fac2b7b17cbb1712cffe2 ocaml(CamlinternalOO) =
6d0d5b328d6db88f403ca4393b4abd38 ocaml(List) = da1ce9168f0408ff26158af757456948
ocaml(Obj) = 5cfae708052c692ea39d23ed930fd64d ocaml(Pervasives) =
8ba3d1faa24d659525c9025f41fd0c57 ocaml(Printf) =
5dbbf45a03b54e6dbfcf39178d0d6341 ocaml(String) =
2c162ab314b2f0a2cfd22d471b2e21ab ocaml(Unix) = 9a46a8db115947409e54686ada118599
ocaml(runtime) = 3.10.1

+ Package ocaml-postgresql-devel-1.7.0-2.fc9 =>
  Requires: ocaml-postgresql = 1.7.0-2.fc9
+ Followed ocaml packaging guidelines.

In build.log I see that
ocamlfind: [WARNING] You have installed DLLs but the directory
/var/tmp/ocaml-postgresql-1.7.0-2.fc9-root-mockbuild/usr/lib/ocaml/stublibs is
not mentioned in ld.conf

I am not sure if this needs to be fixed?

Also, Sorry I am not knowing following thing
- Don't need 'ExcludeArch: ppc64' on Rawhide.
Can you explain this for me? I see no build happened on koji for ppc64.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.