[Bug 435982] Review Request: ocaml-camlidl - Stub code generator and COM binding for Objective Caml

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-camlidl - Stub code generator and COM binding for Objective Caml


https://bugzilla.redhat.com/show_bug.cgi?id=435982


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2008-03-05 05:41 EST -------
Review:
+ package builds in mock (rawhide i386).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=493501
+ rpmlint is NOT silent for SRPM and for RPM.
ocaml-camlidl.i386: E: no-binary
ocaml-camlidl.i386: E: only-non-binary-in-usr-lib
==> ok to accept as per discussed in bug 433783
+ source files match upstream.
4cfb863bc3cbdc1af2502042c45cc675  camlidl-1.05.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no .pc file present.
+ -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.
+ Package ocaml-camlidl-1.05-3.fc9 =>
  Provides: ocaml(Com) = a0cb6a9dbbc61d265c2d03da5ca0ac39
  Requires: /usr/bin/ocamlrun ocaml(Callback) = e5ca1fb5990fac2b7b17cbb1712cffe2
ocaml(Obj) = 5cfae708052c692ea39d23ed930fd64d ocaml(Pervasives) =
8ba3d1faa24d659525c9025f41fd0c57 ocaml(runtime) = 3.10.1
+ Package ocaml-camlidl-devel-1.05-3.fc9 =>
   ocaml-camlidl = 1.05-3.fc9
+ Followed ocaml packaging guidelines.

 SHOULD:
    Consider adding tests to %doc
APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.