[Bug 435572] Review Request: gnome-hearts - Hearts game for GNOME
bugzilla at redhat.com
bugzilla at redhat.com
Fri Mar 7 16:39:57 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gnome-hearts - Hearts game for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=435572
------- Additional Comments From caillon at redhat.com 2008-03-07 11:39 EST -------
(In reply to comment #4)
> For 0.2.1-1:
>
> * License
> - Please change the license tag to "GPLv2+ aned GFDL".
> * Document files under %{_datadir}/gnome/help/ are licensed
> under GFDL.
> * The rest parts are licensed under GPLv2+
>
> * Documents
> - "COPYING" file is rather mandatory for %doc if it
> exists.
Above two items OK.
>
> * desktop-file-install
> - Please call desktop-file-install for installing desktop file.
It is useless here. The app installs it for us. We should only use
desktop-file-install for Fedora-managed specs, not for ones installed by the
application.
>
> * Timestamps
> - I recommend to use
> ------------------------------------------------------
> make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
> ------------------------------------------------------
> to keep timestamps on installed files. This method usually
> works for recent autotool-based Makefiles.
I recommend getting this fixed in autotools, and not tweaking packages.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the Fedora-package-review
mailing list