[Bug 435598] Review Request: joni - Java regexp library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: joni - Java regexp library


https://bugzilla.redhat.com/show_bug.cgi?id=435598


xjakub at fi.muni.cz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xjakub at fi.muni.cz




------- Additional Comments From xjakub at fi.muni.cz  2008-03-10 07:08 EST -------
One informal review remark concerning licensing:

You've used the BSD license in the spec file, but:

There is a MIT license mentioned in pom.xml:
    <license>
      <name>MIT License</name>
      <url>http://www.opensource.org/licenses/mit-license.php</url>
      <distribution>repo</distribution>
    </license>

And there is also the MIT license included in the source files (Modern Style
with sublicense -- see http://fedoraproject.org/wiki/Licensing/MIT for details).

What is a bit confusing is the project's site, because there is a disclaimer:
"Distributed under a tri-license (CPL/GPL/LGPL)". This should be probably
clarified with upstream (for what parts of JRuby this applies), nevertheless
according to the source files now you should use License: MIT.

Otherwise it seems ok for me.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.