[Bug 433547] Review Request: nagios-nsca - nagios passive check daemon

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-nsca - nagios passive check daemon


https://bugzilla.redhat.com/show_bug.cgi?id=433547





------- Additional Comments From xavier at bachelot.org  2008-03-10 14:39 EST -------
(In reply to comment #6)
> Here's another iteration based on the package that you mailed me (thanks!).  I
> think we should keep 'NetSaint' in the description because we're not disabling
> any netsaint functionality. 

Ok

>  I also merged the sed script that was modifying the
> init script into the existing init script patch.  It seemed silly to use both a
> patch and a sed script for the same file:
> 
Agreed.

> http://www.kobold.org/~wart/fedora/nsca.spec
> http://www.kobold.org/~wart/fedora/nsca-2.7.2-4.fc8.src.rpm
> 
> I haven't tried the new init script myself; I'll take your word that it works as
> expected.

I need to diff the old one and the new one to make sure it's ok.

I see you actually used my spec as the new base, I hope this won't disqualify me
for the formal review. I'll put it in the next comment. Also this is my first
formal review, so I'll ask my sponsor to take a look.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.