[Bug 435121] Review Request: dspam - Scalable and open-source content-based spam filter

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dspam - Scalable and open-source content-based spam filter


https://bugzilla.redhat.com/show_bug.cgi?id=435121





------- Additional Comments From ondrejj at salstar.sk  2008-03-10 15:13 EST -------
403 - Forbidden
for http://rpm.binaryhelix.org/dspam-3.8.0-19.src.rpm
Please fix permissions.

Other comments:
- suggested buildroot value is here:
http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473
  please use any higher example
- URL from spec file "Not found!"
- same problem for Source0 !
- prepare buildroot for %install:
http://fedoraproject.org/wiki/Packaging/Guidelines#head-6c809b2e945ca78ae25d040f250be60f73181ef0
- /usr/share/doc/dspam/ is not a path for documentation
I think it is not required to install documentation files, you can include them
in files section also from BUILD directory. Proper path will be automatically
added for packaged files. Leave documentation for subpackages in their own
documentation directories or make a separate -doc subpackage where there is a
lot of docs.
- Libtool archives, foo.la files, should not be included.
http://fedoraproject.org/wiki/Packaging/Guidelines#head-2302ec1e1f44202c9cc4bcce24cb711266557ad7
- please add your name and email in one of suggested format:
http://fedoraproject.org/wiki/Packaging/Guidelines#head-b7d622f4bb245300199c6a33128acce5fb453213

Non blocker suggestion:
- you can use "." at end of sentences in %description (but can't in Summary)

May be an reviewer, which can sponsor you can find more problems. :-)


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.