[Bug 436741] Review Request: ltsp - Linux Terminal Server Project

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ltsp - Linux Terminal Server Project


https://bugzilla.redhat.com/show_bug.cgi?id=436741





------- Additional Comments From matt_domsch at dell.com  2008-03-10 15:52 EST -------
Summary should not include '5'.
License should be: GPLv2 and GPLv2+
Group: specified in both top-level and packages.  Necessary?

rpmlint:
ltsp.src:183: E: hardcoded-library-path in /usr/lib/syslinux/pxelinux.0
ltsp.src:184: E: hardcoded-library-path in /usr/lib/syslinux/pxelinux.0
ltsp-client.x86_64: E: zero-length /etc/lts.conf
ltsp-client.x86_64: W: non-conffile-in-etc /etc/rwtab.d/k12linux.rwtab
ltsp-client.x86_64: E: zero-length /var/lib/random-seed
ltsp-server.x86_64: E: dir-or-file-in-opt /opt/ltsp
ltsp-server.x86_64: W: non-conffile-in-etc /etc/sysconfig/k12_dist
ltsp-server.x86_64: E: zero-length /usr/share/ltsp/chkconfig.d/nbdrootd
ltsp-server.x86_64: E: zero-length /usr/share/ltsp/chkconfig.d/ldminfod
ltsp-server.x86_64: E: zero-length
/usr/share/ltsp/plugins/ltsp-build-client/Gentoo/020-rootpath
ltsp-server.x86_64: E: non-executable-script
/usr/share/ltsp/plugins/ltsp-build-client/Fedora/010-chroot-creator 0644
ltsp-server.x86_64: E: init-script-without-chkconfig-postin /etc/init.d/ltsp-dhcpd
ltsp-server.x86_64: E: init-script-without-chkconfig-preun /etc/init.d/ltsp-dhcpd
ltsp-server.x86_64: E: incoherent-subsys /etc/init.d/ltsp-dhcpd dhcpd
ltsp-server.x86_64: W: service-default-enabled /etc/init.d/ltsp-dhcpd
ltsp-server.x86_64: W: incoherent-init-script-name ltsp-dhcpd
ltsp-vmclient.x86_64: W: no-documentation

naming: ok
spec name matches: ok
meets guidelines: ok
license: ok
license field: needs fixing as noted above
license included: yes in server, but not in client or vmclient subpackages.
english: ok
legible: ok
sources: ok
builds: ok on x86_64 and i386 (the only ones I tested)
exclusivearch: no blocker bug filed that I know of
buildrequires: ok
locales: not used, ok
no shared libs, so no ldconfig.  OK
not relocatable: ok
directory ownership OK
defattr: missing for vmclient subpackage
no duplicate files: ok
clean: ok
code not content: ok
no large docs: ok
no headers: ok
no static libs: ok
no pkgconfig files: ok
no libs: ok
no devel pkg: ok
no libtool archives: ok
no GUI apps: ok
dir ownership: looks OK
%install rm -rf: ok
filenames UTF-8: ok

license included: ok
translated descriptions: no, but ok
builds in mock: ok on i386 and x86_64
compiles on i386 and x86_64
should test: not done
no scriptlets: ok
no subpackages need to include main package: ok
no pkgconfig files: ok
no file deps: ok


follows packaging guidelines best as I can tell.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.