[Bug 435121] Review Request: dspam - Scalable and open-source content-based spam filter

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dspam - Scalable and open-source content-based spam filter


https://bugzilla.redhat.com/show_bug.cgi?id=435121





------- Additional Comments From ondrejj at salstar.sk  2008-03-11 15:03 EST -------
(In reply to comment #17)
> - dspam.i386: W: log-files-without-logrotate /var/log/dspam
> Shall I write a logrotate file even if upstream doesn't provide one?

Sure, why not? You also can send it to upstream.
For example you are using and init.d script, which is not included upstream too.
This is same situation, just for another script.

> - dspam.i386: E: script-without-shebang /var/www/dspam/cgi-bin/admins
> Shall I add shebang even if upstream doesn't provide scripts with it?

You have to consider, what happens after adding shebang. If it is ok, you can do
this fix. In this example you have to fix permissions (remove execute
permission) to fix this bug. It looks like it is an configuration file.

May be proper place for configuration files is to place them somewhere in /etc
and make a symlink (relative) from this place to /etc/...

> - dspam-devel.i386: W: symlink-should-be-relative
> /usr/share/man/man3/dspam_detach.3.gz /usr/share/man/man3/libdspam.3.gz
> I think this stuff comes from upstream installation scripts/makefiles shall I
> fix them? (same applies to spurious-executable-perm errors, I suppose)

Yes. You can make a patch for upstream makefile or you can remove them in spec
file a create new ones.

Sometimes it is different for upstream releases to create relative symlinks for
all OS and distributions, so you have to fix this in package release.

And another problem:
  %dir /var/www
is owned by httpd. You can't include conflicting files in package.
Please, check this for other directories too.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.