[Bug 433187] Review Request: boinc-client - A platform for distributed computing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: boinc-client - A platform for distributed computing
Alias: boinc-client-review

https://bugzilla.redhat.com/show_bug.cgi?id=433187





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-03-12 14:02 EST -------
Umm.. I don't know why I didn't notice before, however
for 5.10.40-8:

* compilation flags
  - From build.log:
----------------------------------------------------------------------------------
  1215  make[2]: Entering directory
`/builddir/build/BUILD/boinc_core_release_5_10_40/client'
  1216  g++ -DHAVE_CONFIG_H -I. -I..  -O3 -fomit-frame-pointer -fforce-addr
-ffast-math -I../lib -I../api -I../db -I../client -I../tools -I../sched
-I../lib/mac -I/usr/include/mysql -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
-fasynchronous-unwind-tables -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE -fno-strict-aliasing -fwrapv -pthread  -I../lib -I../api
-I../db -I../client -I../tools -I../sched -I../lib/mac -I/usr/include/mysql -g
-pipe -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
-fasynchronous-unwind-tables -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE -fno-strict-aliasing -fwrapv -pthread -O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4
-m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -I/usr/include
-I/usr/include/openssl -pthread -MT boinc_client-acct_mgr.o -MD -MP -MF
.deps/boinc_client-acct_mgr.Tpo -c -o boinc_client-acct_mgr.o `test -f
'acct_mgr.C' || echo './'`acct_mgr.C
---------------------------------------------------------------------------------
  Here:
  - Fedora does not allow -fomit-frame-pointer because this option
    makes debugging difficult
  - Also, -ffast-math is discouraged because this changes precision of
    calculation, which may make debugging difficult.

* restorecon
---------------------------------------------------------------------------------
%post
/sbin/restorecon %{_localstatedir}/lib/boinc/error.log
/sbin/restorecon %{_localstatedir}/lib/boinc/boinc.log
---------------------------------------------------------------------------------
  - First of all, these two files are not owned by any packages
---------------------------------------------------------------------------------
$ LANG=C rpm -qf /var/lib/boinc/error.log 
file /var/lib/boinc/error.log is not owned by any package
----------------------------------------------------------------------------------

  - Well, I am not familiar with SELinux, however:
    * at the first time boinc-client is installed, these two 
      files do not exist. So restorerecon does not do anything.
    * Then sysadmin activates boinc-client service. At this stage
      SELinux shows AVC denial? (I turn SELinux off...)
    I guess the best way to solve SELinux issue is to ask Dan Walsh
    for help after this review is passed?


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.