[Bug 436356] Review Request: openoffice.org-extendedPDF - Create PDF with hyperlinks, bookmarks and more

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openoffice.org-extendedPDF -  Create PDF with hyperlinks, bookmarks and more


https://bugzilla.redhat.com/show_bug.cgi?id=436356





------- Additional Comments From caolanm at redhat.com  2008-03-13 05:14 EST -------
- Generic Guidelines -

- MUST: rpmlint must be run on every package. The output should be posted in the
review. i.e. NONE for the .src.rpm or noarch.rpm -> PASS
- The package must be named according to the Package Naming Guidelines, same as
upstream, which is a sane name + the openoffice.org- prefix required by the
draft OOo extensions naming scheme -> PASS
- MUST: The spec file name must match the base package %{name} -> PASS
- MUST: The package must meet the  Packaging Guidelines -> PASS
- MUST: The package must be licensed with a Fedora approved license and meet the
 Licensing Guidelines. -> source is in GPLv2+ -> PASS
- MUST: The License field in the package spec file must match the actual
license. -> FAIL, close, but the source I believe is GPLv2+, not just GPLv2.
Easy fix
- MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc -> PASS
- MUST: The spec file must be written in American English. -> PASS
- MUST: The spec file for the package MUST be legible -> PASS
- MUST: The sources used to build the package must match the upstream source, as
provided in the spec -> PASS
- MUST: The package must successfully compile and build into binary rpms on at
least one supported architecture. -> PASS
- MUST: If the package does not successfully compile... -> PASS
- MUST: All build dependencies must be listed in BuildRequires -> PASS
- MUST: The spec file MUST handle locales properly. -> PASS
- MUST: Every binary RPM package ... -> PASS
- MUST: If the package is designed to be relocatable -> PASS
- MUST: A package must own all directories that it creates... -> PASS
- MUST: A package must not contain any duplicate files -> PASS
- MUST: Permissions on files must be set properly. -> PASS
- MUST: Each package must have a %clean section -> PASS
- MUST: Each package must consistently use macros -> PASS
- MUST: The package must contain code, or permissable content -> PASS
- MUST: Large documentation files should go in a -doc subpackage -> PASS
- MUST: If a package includes something as %doc, it must not affect the runtime
of the application. -> PASS
- MUST: Header files must be in a -devel package. -> PASS
- MUST: Static libraries must be in a -static package. -> PASS
- MUST: Packages containing pkgconfig(.pc) files must... -> PASS
- MUST: If a package contains library files...  -> PASS
- MUST: In the vast majority of cases, devel packages... -> PASS
- MUST: Packages must NOT contain any .la libtool archives -> PASS
- MUST: Packages containing GUI applications must... -> PASS
- MUST: Packages must not own files or directories already owned by other
packages. -> PASS
- MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}
-> PASS
- MUST: All filenames in rpm packages must be valid UTF-8. -> PASS

"Shoulds" looks good too.

- Draft OOo Extensions Guidelines -
- Must have a %postun of 'unopkg list --shared > /dev/null 2>&1' -> PASS
- Should be both installed unpacked and then registered with 'unopkg --link' -> PASS
Unpacked Extensions Must be installed in a dir called NAME.oxt, NAME.uno.pkg or
NAME.zip -> PASS
- An extension should normally just be able to just Require: an appropriate
openoffice.org component e.g. openoffice.org-core -> PASS
- extensions Must be named openoffice.org-FOO -> PASS
- The license Must be acceptable, and the package Must be build-able from
source. -> PASS (code is in StarBasic, so *is* source rather than built from source)

a) so, change the license from GPLv2 to GPLv2+ and we're good. 
b) Also (my fault) I originally had some rules about
-env:JFW_PLUGIN_DO_NOT_CHECK_ACCESSIBILITY' and unopkg, but decided to just fix
it in unopkg instead so that's dropped now and can be removed from the package.

I attach a replacement .spec with the above changes. 

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.