[Bug 225792] Merge Review: gfs2-utils

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gfs2-utils


https://bugzilla.redhat.com/show_bug.cgi?id=225792





------- Additional Comments From kevin at tummy.com  2008-03-15 13:23 EST -------

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPLv2)
See below - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
See below - Sources match upstream md5sum:
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output.
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have dist tag
See below - check for outstanding bugs on package.

Issues:

1. The License tag is not right. Should be "GPLv2"

2. You might ask upstream to include a copy of the GPL with the package.
Not a blocker.

3. Is there an upstream download URL you can place in the
Source0 line? Or can you comment where to get the source?
See: http://fedoraproject.org/wiki/Packaging/SourceURL

4. The URL seems to no longer be correct. That redirects me to:
http://sources.redhat.com/cluster/wiki

5. Does parallel make not work with this package?
If it does, please change the 'make' to 'make %{?_smp_mflags}'
If not, please add a note that it doesn't work.

6. You might add:
Requires(preun): /sbin/service
and stop the service in preun?
See:
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-a6d7a1ed9d77dbb8d4af067378a79b838aebb20a

7. rpmlint says:

gfs2-utils.src: W: invalid-license GPL
gfs2-utils.x86_64: W: invalid-license GPL
gfs2-utils-debuginfo.x86_64: W: invalid-license GPL

These will be fixed by changing to 'GPLv2'

gfs2-utils.x86_64: W: spurious-executable-perm /usr/share/man/man8/gfs2_convert.8.gz
gfs2-utils.x86_64: W: spurious-executable-perm /usr/share/man/man8/gfs2_fsck.8.gz
gfs2-utils.x86_64: W: spurious-executable-perm /usr/share/man/man8/gfs2_mount.8.gz
gfs2-utils.x86_64: W: spurious-executable-perm /usr/share/man/man8/gfs2_tool.8.gz
gfs2-utils.x86_64: W: spurious-executable-perm /usr/share/man/man8/mkfs.gfs2.8.gz
gfs2-utils.x86_64: W: spurious-executable-perm /usr/share/man/man8/gfs2_grow.8.gz
gfs2-utils.x86_64: W: spurious-executable-perm /usr/share/man/man8/gfs2_quota.8.gz
gfs2-utils.x86_64: W: spurious-executable-perm /usr/share/man/man8/gfs2_jadd.8.gz
gfs2-utils.x86_64: W: spurious-executable-perm /usr/share/man/man8/gfs2.8.gz

For some reason your man pages are not the right mode.
Can you file a bug upstream to install them as 644?

gfs2-utils.x86_64: E: non-standard-executable-perm /sbin/gfs2_jadd 0775

Why 775 here and not 755?

gfs2-utils.x86_64: E: missing-mandatory-lsb-keyword Description in
/etc/rc.d/init.d/gfs2
gfs2-utils.x86_64: E: missing-mandatory-lsb-keyword Short-Description in
/etc/rc.d/init.d/gfs2

Might fix up the init script to have the lsb keywords in it.

gfs2-utils.x86_64: W: incoherent-init-script-name gfs2

This is due to the init script not being the same name as the package.
Ignore, unless you want to re-name it to 'gfs2-utils' instead?

8. Looking at the outstanding bugs against this package I see two:

224154 - Should just be closed now?

429769 - Can this be closed now? Is rawhide up to date?

If you could address all the above, then let me know I will re-run my checks
and we can get this closed out. Let me know if there are any questions.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.