[Bug 433187] Review Request: boinc-client - A platform for distributed computing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: boinc-client - A platform for distributed computing
Alias: boinc-client-review

https://bugzilla.redhat.com/show_bug.cgi?id=433187





------- Additional Comments From xjakub at fi.muni.cz  2008-03-16 10:03 EST -------
> * compilation flags

Fixed (as Patch1). Shouldn't this be mentioned somewhere (in best case directly
at  http://fedoraproject.org/wiki/Packaging/Guidelines)? I haven't found it
anywhere...

> * restorecon

Now I touch both of those files (boinc.log, error.log) in the %install section
and later change their SELinux file_type from var_lib_t to var_log_t (following
 http://fedoraproject.org/wiki/PackagingDrafts/SELinux). I noticed that the
majority of files handled by logrotate has this file_type (because they're in
/var/log which is of course much more correct).

The problem for me with this issue is that it is hard to reproduce. On my own PC
it happened only once that setroubleshoot complained about accessing those files
and even running logrotate manually (with --force) works fine (files are
rotated, no SELinux trouble).

NOTE: Before updating to this package, please remove error.log and boinc.log!
Otherwise the relabeling doesn't work (don't know why) and both files remain as
var_lib_t.

If this will work, I'll change the location of both logfiles from /var/lib/boinc
directly to /var/log so that we can get rid of additional dependency on
policycoreutils (and from a logical point of view this is also the appropriate
place to store logfiles, IMHO).

New SPEC file and SRPM:
http://www.fi.muni.cz/~xjakub/boinc/boinc-client-5.10.45-1.20080315svn.fc8.src.rpm
http://www.fi.muni.cz/~xjakub/boinc/boinc-client.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.