[Bug 436239] Review Request: joda-time - Java date and time API

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: joda-time - Java date and time API


https://bugzilla.redhat.com/show_bug.cgi?id=436239





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-03-17 03:52 EST -------
For 1.5.2-2:

* Requires
  - For -javadocs subpackages:
-----------------------------------------------------
Requires:       %{name}-%{version}-%{release}
                      ^^^^
-----------------------------------------------------
    This must be %{name} = %{version}-%{release}

* src/testdata/
  - The files under src/testdata seem binary (although
    I can see almost all parts by less command).
    If they can safely be igored, please remove all of
    them at %prep (I don't know if they can be removed,
    however even if they are removed joda-time compiles:
    http://koji.fedoraproject.org/koji/taskinfo?taskID=519102 )

* tzdata
  - This package uses tzdata (please check files under
    src/java/org/joda/time/tz/src/) and the version is
    2007k.

    However from
    ftp://elsie.nci.nih.gov/pub/
    it seems current latest tzdata is 2008a (you can find 
    tzdata2008a.tar.gz from the URL above) and tzdata of Chile
    is revised.
    ! Note
      Current Fedora rawhide tzdata is also 2007k, however changelog
      shows Fedora tzdata maintainer patched for Chilean tzdata
      and essentially it is the same as 2008a.
    The history of joda-time shows the upstream does not always
    sync tzdata part with the URL above.

    IMO
    - This package should have tzdataXXXXx.tar.gz as Source(1,
      for example) and override files under src/java/org/joda/time/tz/src/
      by the files in tzdata tarball.
      This means that you have to update joda-time every time
      tzdata is updated (usually you can notice by Fedora tzdata update).

      Also, in this case it is better that the EVR (Epoch-Version-Release)
      of tzdata refects the version of tzdata used for joda-time
      (say, 1.5.2-2.tzdata2008a.fc9?).

    - Or are there any way thatjoda-time use contents in tzdata rpm
      directly?

* Documents
  - IMO it is better that the following files is added
    to %doc.
-----------------------------------------------------
RELEASE-NOTES.txt
ToDo.txt
-----------------------------------------------------

* javadoc
  - Mark both
-----------------------------------------------------
%dir %{_javadocdir}/%{name}-%{version}
%{_javadocdir}/%{name}-%{version}/*
-----------------------------------------------------
    as %doc.
  ! Note
    The above two lines can be replaced by
-----------------------------------------------------
%doc %{_javadocdir}/%{name}-%{version}/
-----------------------------------------------------
    The %files entry <a_directory>/ (not %dir <a_directory>)
    contains the directory itself and all files/directories/etc
    under the directory.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.