[Bug 437400] Review Request: msr-tools - tools to read/write processor model specific registers

bugzilla at redhat.com bugzilla at redhat.com
Tue Mar 18 14:48:20 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: msr-tools - tools to read/write processor model specific registers


https://bugzilla.redhat.com/show_bug.cgi?id=437400





------- Additional Comments From lkundrak at redhat.com  2008-03-18 10:48 EST -------
1.) Package currently won't build:

install rdmsr %{buildroot}%{_sbindir}/rdmsr
install wrmsr %{buildroot}%{_sbindir}/wrmsr

Did you mean "install -D there"?

2.) Some cosmetical things:

msr-tools.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 36)
msr-tools.src: W: summary-ended-with-dot Collection of tools for reading/writing
CPU model specific registers.
msr-tools.x86_64: W: incoherent-version-in-changelog 1.1.2 1.1.2-1.fc8

the last one is the same as bug #437397 comment #3 -- the changelog header
should end with " - 1.1.2-1" (no dist tag there, contrary to what rpmlint output
above suggests)

I see no more issues with the package. I'll approve it once these are addressed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list