[Bug 437981] Review Request: eigen - A lightweight C++ template library for vector and matrix math

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eigen -  A lightweight C++ template library for vector and matrix math


https://bugzilla.redhat.com/show_bug.cgi?id=437981


kevin at tigcc.ticalc.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From kevin at tigcc.ticalc.org  2008-03-18 13:04 EST -------
MUST Items:
+ rpmlint output: none
+ named and versioned according to the Package Naming Guidelines:
+ spec file name matches base package name
+ Packaging Guidelines:
  + License GPLv2+ with exceptions OK, matches actual license
  + No known patent problems
  + No emulator, no firmware, no binary-only or prebuilt components
  + Complies with the FHS
  + proper changelog, tags, BuildRoot, Requires, BuildRequires, Summary, 
Description
  + no non-UTF-8 characters
  + relevant documentation included
  + nothing to compile, so RPM_OPT_FLAGS are irrelevant
  + nothing to compile (noarch package), so no debuginfo package
  + no static libraries nor .la files
  + no duplicated system libraries
  + no binaries => no rpaths
  + no configuration files, so %config guideline doesn't apply
  + no init scripts, so init script guideline doesn't apply
  + no GUI executables, so no .desktop file needed
  + ... and thus no desktop-file-install needed either
  + no timestamp-clobbering file commands
  + _smp_mflags used
  + scriptlets are valid
  + not a web application, so web application guideline doesn't apply
  + no conflicts
+ complies with all the legal guidelines
+ license included as %doc
+ source matches upstream:
  MD5SUM: 960d7e5fb6542270eae4d53ca99b607c
  SHA1SUM: 32400616c4866eab158115c556df330b077644a3
+ builds on at least one arch (F8 i386)
+ no known non-working arches, so no ExcludeArch needed
+ BuildRequires are complete (cmake, doxygen, graphviz, tex(latex))
+ no translations, so translation/locale guidelines don't apply
+ no shared libraries, so no ldconfig call needed
+ package not relocatable
+ ownership correct (owns package-specific directories, doesn't own directories 
owned by another package)
+ no duplicate files in %files
+ permissions correct, defattr used correctly
+ %clean section present and correct
+ macros used where possible
+ no non-code content
+ no large documentation files, so no -doc package needed
+ %doc files not required at runtime
+ all header files in -devel
+ no static libraries, so no -static package needed
+ no .pc files, so no Requires: pkgconfig needed
+ no .so symlinks vs. plugins
+ no main package (as this is a headers-only library), -devel Provides: %{name} 
= %{version}-%{release} instead, OK
+ no .la files
+ no GUI executables, so no .desktop file needed
+ buildroot is deleted at the beginning of %install
+ all filenames are valid UTF-8

SHOULD Items:
+ license included as %doc
+ no translations for description and summary provided by upstream
* skipping mock test
* skipping all arch test
* skipping functionality test
+ scriptlets are sane
+ no subpackages other than -devel, so "Usually, subpackages other than devel 
should require the base package using a fully versioned dependency." is 
irrelevant
+ no .pc files, so "placement of .pc files" is irrelevant
+ no file dependencies

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.