[Bug 434906] Review Request: xosview - OS resource viewer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xosview - OS resource viewer


https://bugzilla.redhat.com/show_bug.cgi?id=434906


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-03-20 14:15 EST -------
Nice application :)

Well for 1.8.2-5:
* License
  - The license tag "GPL" is not valid for Fedora
    http://fedoraproject.org/wiki/Packaging/LicensingGuidelines
    http://fedoraproject.org/wiki/Licensing

  ! Note
    When the codes under GPL and the codes under "BSD" are used
    for a component:
    - If "BSD" means 3 clause (i.e. without advertising clause),
      the whole license of the component becomes just "GPL"
      (in this case the license tag is GPLv2+, for example)
      as GPL is more strict than BSD
    - If "BSD" means 4 clause (i.e. with advertising clause),
      this is incompatible with GPL (at any version).
    So please check that no codes shipped under "BSD with
    advertising" license are used for this package.

* SourceURL
  - For sourceforge software, please refer to
    http://fedoraproject.org/wiki/Packaging/SourceURL

* %configure
-----------------------------------------------------------------
CXXFLAGS="$RPM_OPT_FLAGS" \
%configure --disable-linux-memstat --x-libraries=/usr/lib
--x-includes=/usr/include --prefix=/usr
-----------------------------------------------------------------
  - Please check if CXXFLAGS="$RPM_OPT_FLAGS" is really needed.
  - --prefix=/usr is not needed
    You can check what %configure actually does by
    $ rpm --eval %configure

  Also:
  - Check if --x-libraries=/usr/lib --x-includes=/usr/include is really
    needed
    * These are usually detected automatically
    * Also --x-libraries=/usr/lib is actually wrong for 64bit architecture

* Fedora specific compilation flags
-----------------------------------------------------------------
   129  + make -j4 all
   130  cd ./linux && make
   131  make[1]: Entering directory `/builddir/build/BUILD/xosview-1.8.3/linux'
   132  g++ -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune
=generic -fasynchronous-unwind-tables -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -fstack-protector --param=ssp-buffer-size
=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -Wall -O4
-I/usr/include -DXOSVIEW_VERSION=\"1.8.3\" -I/builddir/build/
BUILD/xosview-1.8.3 -I/builddir/build/BUILD/xosview-1.8.3/linux
-DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\" -DPAC
KAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DHAVE_BOOL=1 -DLONG_LONG=long\ long
-DHAVE_SNPRINTF=1 -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 
-DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1
-DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHA
VE_UNISTD_H=1 -DHAVE_IOSTREAM=1 -DHAVE_FSTREAM=1 -DHAVE_XPM=1 -DGNULIBC=1
-DUSESYSCALLS=1 -DHAVE_USLEEP=1  -O2 -g -pipe -Wall -Wp,-D_FO
RTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32
-march=i386 -mtune=generic -fasynchronous-unwind-tables -W
all -O4 -I/usr/include -DXOSVIEW_VERSION=\"1.8.3\"
-I/builddir/build/BUILD/xosview-1.8.3 -I/builddir/build/BUILD/xosview-1.8.3/linux -D
PACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\"
-DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DHAVE_BOOL=1 -DLONG_LON
G=long\ long -DHAVE_SNPRINTF=1 -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1
-DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEM
ORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1
-DHAVE_UNISTD_H=1 -DHAVE_IOSTREAM=1 -DHAVE_FSTREAM=1 -DHAVE_XPM=1 -DGN
ULIBC=1 -DUSESYSCALLS=1 -DHAVE_USLEEP=1  -I..  -c cpumeter.cc -o cpumeter.o
-----------------------------------------------------------------
  - Here Fedora uses optimization level "-O2" by default, which is replaced
    by the latter level "-O4" and Fedora does not allow this.

* Macros
  - Please use macros when possible.
    * For example, /usr -> %{_prefix}
      %_prefix/bin -> %_bindir %_prefix/share/man -> %_mandir

* Desktop file
  - When installing desktop files, desktop-file-install must be
    called (please check "desktop-file-install usage" of
    http://fedoraproject.org/wiki/Packaging/Guidelines)
  - The Categories "Application" "X-Red-Hat-Base" are deprecated
    and should be removed.

* rpmlint issue
  - You can check some gereric packaging issues by using rpmlint
    (in rpmlint rpm)
-------------------------------------------------------------
xosview.src:252: W: macro-in-%changelog clean
xosview.src: W: summary-ended-with-dot An X Window System utility for monitoring
system resources.
-------------------------------------------------------------
    * When using macros in %changelog, please use %% (for example
      %%clean) to avoid macros from being expanded
    * Summary should not be ended with dot.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.