[Bug 222338] Review Request: initng-conf-gtk - InitNG configuration and control utility

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: initng-conf-gtk - InitNG configuration and control utility


https://bugzilla.redhat.com/show_bug.cgi?id=222338





------- Additional Comments From dm at mensa.se  2008-03-21 02:41 EST -------
(In reply to comment #15)
> again lots of time has passed but I'm going to continue the review now finally.

Nice. Don't really know how many people are interested anymore now that upstart
seems to be the preferred over initng in Fedora...

The new srpm is
http://download.initng.org/initng-gui/initng-conf-gtk/initng-conf-gtk-0.5.1-3.fc8.src.rpm

> > > - gtk-update-icon-cache must be executed with '|| :' at the end (instead of
> > ';')
> > > so %post doesn't fail completely if something goes wrong
> > 
> > Fixed
> Still wrong:
> You're using ${_bindir} instead of %{_bindir}, probably a typo only. Please
fix it.

Yep, must've been a typo. Fixed now.

> > > - update-desktop-database is missing in %post
> > 
> > Fixed
> Confirmed; however if I get
>
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-de6770dd9867fcd085a73a4700f6bcd0d10294ef
> right, desktop-file-utils is needed in neither Requires(post) nor
> Requires(postun) anymore, so you can remove it from Requires(post).

Fixed.

> One small issue left:
> The description should say more than the summary, however if there's nothing
> more to say, finish the sentence with a period at least.

There is more to say. Not much for writing long texts though :-)
I wrote a bit longer sentence for the description now...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.