[Bug 433778] Review Request: fsvs - full system versioning using subversion repositories

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fsvs - full system versioning using subversion repositories


https://bugzilla.redhat.com/show_bug.cgi?id=433778





------- Additional Comments From davidf at sjsoft.com  2008-03-24 01:17 EST -------
(In reply to comment #3)
> I'll do a pre-review:
Thanks :-)
 
> Package Review Requirements:
> MUST:
> - rpmlint fsvs-1.1.12-3.fc8.src.rpm output:
>  W: fsvs summary-ended-with-dot Fast System VerSioning - A complete
> backup/restore/versioning tool for file trees, with a subversion repository as
> the backend.
>  E: fsvs summary-too-long Fast System VerSioning - A complete
> backup/restore/versioning tool for file trees, with a subversion repository as
> the backend.
>  E: fsvs description-line-too-long It is a complete backup/restore/versioning
> tool for all files in a directory tree or whole filesystems, with a subversionTM
> repository as the backend.
>  E: fsvs description-line-too-long If uses a different system for storing local
> version information that doesn't clutter directories like /etc like .svn
> directories in standard subversion would
>  E: fsvs description-line-too-long A nice capability is to cope with local
> adjustments for different machines (using branching-like techniques), so that
> most of the space needed for the backup of system-files (/bin, /usr, ...) can be
> shared between machines.
>  W: fsvs invalid-license GNU GPL
All fixed

>  E: fsvs non-utf8-spec-file fsvs.spec
I didn't get this on my version of rpmlint (rpmlint-0.82-2.fc8), file fsvs.spec
returns "UTF-8 Unicode English text", and I can't see any invalid characters...

> - package should satisfy packaging guidelines
>   You need to make sure all lines are less than 80 characters long in the
> description
>   You should also shorten your summary and remove the period
Fixed as above

> ? package successfully builds on at least one architecture
Builds on i386, but will obviously wait for next review

> - does not use Prefix: /usr
>    Why do you redefine man_dir and doc_dir and manually place files there?
> 
> - consistent use of macros
>   Why do you redefine doc_dir and man_dir?
>  
> Could you explain your choices for renaming/changing the directories?
My fault - didn't realize doc_dir and man_dir were already defined. Fixed.

New files at:
Spec URL: http://davidf.sjsoft.com/fedora/fsvs.spec
SRPM URL: http://davidf.sjsoft.com/fedora/fsvs-1.1.12-5.fc8.src.rpm
i386 RPM URL: http://davidf.sjsoft.com/fedora/fsvs-1.1.12-5.fc8.i386.rpm

Thanks again

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.