[Bug 427674] Review Request: themonospot -application that can be used to scan an avi file and extract some informations about audio and video data flow

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: themonospot -application that can be used to scan an avi file and extract some informations about audio and video data flow


https://bugzilla.redhat.com/show_bug.cgi?id=427674





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-03-24 09:33 EST -------
Okay, a few more things.

For 0.6.5.4-1:
* %{name}, %{release} tag on Source
  - I suggest to use
-----------------------------------------------------
Source:
http://www.integrazioneweb.com/themonospot/packages/fedora/%{name}-%{version}.tar.gz
-----------------------------------------------------
    With this you don't have to modify SourceURL when the version
    is upgraded.

* License
  - README reads that this is released under GPLv2 only so
    the License tag must be "GPLv2", not "GPLv2+".

* Parallel make
  - Support parallel make if possible, otherwide write a comment
    in the spec file that Makefile in this package does not support it.
    Check the section "Parallel make" of
    http://fedoraproject.org/wiki/Packaging/Guidelines

* Documents
  - Please add README to %doc.

* %{?dist} tag in changelong
  - must be removed as this causes to change the %changelog entry
    when %dist actually changes (especially on rawhide).
    Simply
-------------------------------------------------------
* Fri Jan 04 2008 hman <hmandevteam at gmail.com> 0.6.5.4-1
- ....
-------------------------------------------------------
    is enough.

* Empty debuginfo file
  - rpmlint shows
--------------------------------------------------------
themonospot-debuginfo.i386: E: empty-debuginfo-package
--------------------------------------------------------
    This is very common for mono packages. To prevent debuginfo
    rpm from being created, please follow the section
    "Useless or incomplete debuginfo packages due to other reasons" of
    http://fedoraproject.org/wiki/Packaging/Debuginfo

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.