[Bug 438445] Review Request: python-cjson - Fast JSON encoder/decoder for Python
bugzilla at redhat.com
bugzilla at redhat.com
Tue Mar 25 09:54:06 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: python-cjson - Fast JSON encoder/decoder for Python
https://bugzilla.redhat.com/show_bug.cgi?id=438445
tim.lauridsen at googlemail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
------- Additional Comments From tim.lauridsen at googlemail.com 2008-03-25 05:54 EST -------
MUST:
* package is named appropriately
* it is legal for Fedora to distribute this
* license field matches the actual license.
* license is open source-compatible.
* specfile name matches %{name}
* verify source and patches (md5sum matches upstream, know what the patches do)
4d55b66ecdf0300313af9d030d9644a3 python-cjson-1.0.5.tar.gz
* summary and description fine
* correct buildroot
* %{?dist} is used
* license text included in package and marked with %doc
* package meets FHS (http://www.pathname.com/fhs/)
* changelog format fine
* Packager tag not used
* Vendor tag not used
* Distribution tag not used
* License used and not Copyright
* Summary tag does not end in a period
* specfile is legible
* package successfully compiles and builds on at least x86_64
* BuildRequires are proper
* make sure lines are <= 80 characters
* specfile written in American English
* no -doc sub-package necessary
* no libraries
* no rpath
* no config files
* not a GUI app
* no -devel sub-package necessary
* macros used appropriately and consistently
* no %makeinstall
* install section must begin with rm -rf $RPM_BUILD_ROOT or %{buildroot}
* no locale data
* split Requires(pre,post) into two separate lines
* package not relocatable
* package contains code
* package owns all directories and files
* no %files duplicates
* file permissions fine
* %defattrs present ( %defattr(-, root, root, -))
* %clean present
* %doc files do not affect runtime
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the Fedora-package-review
mailing list