[Bug 439195] Review Request: perl-Task-Weaken - Ensure that a platform has weaken support

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Task-Weaken - Ensure that a platform has weaken support


https://bugzilla.redhat.com/show_bug.cgi?id=439195


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From panemade at gmail.com  2008-03-28 00:08 EST -------
Review:
+ package builds in mock.
Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=535496
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
684c2bd2a76f320679fd2df938467e01  Task-Weaken-1.02.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
t/01_compile....ok
t/02_weaken.....ok
t/98_pod........skipped
        all skipped: Author tests not required for installation
t/99_pmv........skipped
        all skipped: Author tests not required for installation
All tests successful, 2 tests skipped.
Files=4, Tests=21,  1 wallclock secs ( 0.10 cusr +  0.02 csys =  0.12 CPU)

+ Package perl-Task-Weaken-1.02-1.fc9=>
  Provides: perl(Task::Weaken) = 1.02
  Requires: perl >= 0:5.005 perl(strict) perl(vars)


SHOULD:
  License tag MUST be "GPL+ or Artistic"

update new SRPM and will APPROVE this review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.