[Bug 436677] Review Request: xxdiff

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xxdiff


https://bugzilla.redhat.com/show_bug.cgi?id=436677





------- Additional Comments From wolfy at nobugconsulting.ro  2008-03-28 22:43 EST -------
I assume you meant http://xfs.org/~cattelan/xxdiff-3.2-2.fc9.src.rpm  :)

Mind that a bug should be moved to ASSIGNED state when someone actually claims
the bug for review.

Here are a couple of things I've noticed after examining the scratch build from
http://koji.fedoraproject.org/koji/taskinfo?taskID=537125 and your spec:
  minor: python-devel will pull in python, so there is no need to BR python too.
  important: Please replace the occurrence of $RPM_BUILD_ROOT with %{buildroot}
(you've used the last one 3 times and the packaging policy mandates using one or
another but not both in the same spec)
  important: your %build step does not use the RPM_OPT flags mandated by fedora
  medium: rpmlint has complains about your src.rpm:
      W: non-standard-group Application/Text


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.