[Bug 285551] Review Request: idw-gpl - Java Swing based docking windows framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: idw-gpl - Java Swing based docking windows framework


https://bugzilla.redhat.com/show_bug.cgi?id=285551





------- Additional Comments From overholt at redhat.com  2008-05-01 14:50 EST -------
Hi Jerry.  Things look great.  I only have a few questions.

? = maybe or a question I have
OK = okay (surprisingly)
X = please fix

? license field matches the actual license.
  - it looks like they don't specify a version of the GPL.  Is "v2+"
    what we should assume here?
? Can you copy or move the comments about the patches to above the Patch
  lines?  Have you considered offering them to upstream?
? Have you compared the JAR we get with the upstream one?
? (pedantic) in Summary:  "Java Swing based" -> "Java Swing-based"
OK rpmlint on srpm
  idw-gpl.src: W: non-standard-group Development/Libraries/Java
  Don't worry about this.
? consider using cp -p to preserve timestamps
X in %files, change %{_javadir}/*.jar to %{_javadir}/%{name}* (or %{name}*.jar)
X in %files javadoc, change %{_javadocdir}/* to
  %{_javadocdir}/%{name}*
OK - the final provides and requires of the binary RPMs look fine
OK - run rpmlint on the binary RPMs
   idw-gpl.i386: W: non-standard-group Development/Libraries/Java
   idw-gpl-javadoc.i386: W: non-standard-group Development/Libraries/Java
  Don't worry about these.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.