[Bug 444165] Review Request: mkrdns - automatic reverse DNS zone generator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mkrdns - automatic reverse DNS zone generator


https://bugzilla.redhat.com/show_bug.cgi?id=444165


opensource at till.name changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |opensource at till.name
               Flag|                            |fedora-review?




------- Additional Comments From opensource at till.name  2008-05-03 15:44 EST -------
NEEDSWORK: rpmlint
mkrdns.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 11)
- after Buildarch: and Requires: you inserted tabs but after all other tags you
only used spaces, therefore you should change this. You should remove the
"Requires" anyhow, because they are already added automatically by rpm for perl
requirements.

Naming: ok
License: ok (GPLv2+), not included
Building: ok, builds in koji
Clean section: ok
Macro Usage: ok
Source Package: ok, matches upstream, latest version:
474ffb39d1eb615d0e9d8a7d52a27953  mkrdns-3_3.gz
474ffb39d1eb615d0e9d8a7d52a27953  mkrdns-3.3-1.fc8/mkrdns-3_3.gz

Buildroot: ok
%files: ok

Besides the mixed whitespace, there is another minor issue:
You write /usr/bin/pod2man instead of just pod2man, which does not make sense to
me, because on my machine install is also in /usr/bin and you rely on /usr/bin
being in the path there.

Also the timestamp of the executable is lost, maybe you can change the spec to
preserve it, but I do not know a good way to do this.

In conclusion: Remove the tab after Buildarch, remove the Requires: and remove
the /usr/bin from the pod2man invocation, then I will approve this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.