[Bug 445077] Review Request: lsnipes - A text-mode maze game
bugzilla at redhat.com
bugzilla at redhat.com
Sun May 4 17:14:56 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: lsnipes - A text-mode maze game
https://bugzilla.redhat.com/show_bug.cgi?id=445077
jonstanley at gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonstanley at gmail.com
------- Additional Comments From jonstanley at gmail.com 2008-05-04 13:14 EST -------
I am not sponsored, this is an unofficial review.
- Package meets naming and packaging guidelines
- Spec file matches base package name. OK
- Spec has consistant macro usage. OK
- Meets Packaging Guidelines. OK
- License OK
- License field in spec matches OK
- License file included in package OK
- Spec in American English OK
- Spec is legible. OK
- Sources match upstream md5sum:
$ md5sum ../SOURCES/lsnipes-0.9.4.tgz lsnipes-0.9.4.tgz
ea5f41dd7942ec6e0cc1187ba78dfc5a ../SOURCES/lsnipes-0.9.4.tgz
ea5f41dd7942ec6e0cc1187ba78dfc5a lsnipes-0.9.4.tgz
SCRATCH BULD FOR BELOW: http://koji.fedoraproject.org/koji/taskinfo?taskID=594810
- Package needs ExcludeArch NA
- BuildRequires correct OK
- Spec handles locales/find_lang N/A
- Package is relocatable and has a reason to be. N/A
- Package has %defattr and permissions on files is good.
- Package has a correct %clean section. OK
- Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) NO
- Package is code or permissible content. OK
- Doc subpackage needed/used. NA
- Packages %doc files don't affect runtime. OK
- Headers/static libs in -devel subpackage. NA
- Spec has needed ldconfig in post and postun NA
- .pc files in -devel subpackage/requires pkgconfig NA
- .so files in -devel subpackage. NA
- -devel package Requires: %{name} = %{version}-%{release} NA
- .la files are removed. NA
- Package is a GUI app and has a .desktop file NA
- Package compiles and builds on at least one arch. OK
- Package has no duplicate files in %files. OK
- Package doesn't own any directories other packages own. OK
- Package owns all the directories it creates. NA
- No rpmlint output. OK
$ rpmlint lsnipes-0.9.4-2.fc9.x86_64.rpm
$
- final provides and requires are sane:
(include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo
=; rpm -qp --requires $i; echo; done
manually indented after checking each line. I also remove the rpmlib junk
and anything provided by glibc.)
- lsnipes = 0.9.4-2.fc9
=
- libX11.so.6()(64bit)
- libncurses.so.5()(64bit)
- libtinfo.so.5()(64bit)
SHOULD Items:
- Should build in mock. OK
- Should build on all supported archs OK
- Should function as described. Didn't really test - it runs, display is weird,
suspect that's due to the wrong fonts per upstream webpage.
- Should have sane scriptlets. NA
- Should have subpackages require base package with fully versioned depend. NA
- Should have dist tag OK
- Should package latest version OK
- check for outstanding bugs on package. (For core merge reviews) NA
MUST fix:
Specify proper buildroot.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the Fedora-package-review
mailing list