[Bug 445152] Review Request: yacpi - ncurses based acpi viewer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: yacpi - ncurses based acpi viewer


https://bugzilla.redhat.com/show_bug.cgi?id=445152





------- Additional Comments From sven at lank.es  2008-05-05 03:03 EST -------
> It is recommended to use macros instead of using fixed paths.

Fixed. I'm also now using %{_defaultdocdir} while converting the changelog to
UTF8 - is that correct there?

> Based on the header of get_cpu.* files, I think that the correct 
> license tag is GPLv2+.

You are right. I don't know why I entered GPLv2

> The presence of the explicit CFLAGS line in the Makefile prohibits the build
> process to use the mandatory Fedora compile flags.

Removed.

New SRPM: http://sven.lank.es/Fedora/SRPM/yacpi-3.0.1-6.fc9.src.rpm
SPEC: http://sven.lank.es/Fedora/SPECS/yacpi.spec


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.