[Bug 445153] Review Request: libacpi - General purpose library for ACPI

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libacpi - General purpose library for ACPI


https://bugzilla.redhat.com/show_bug.cgi?id=445153





------- Additional Comments From sven at lank.es  2008-05-05 03:37 EST -------
> Please do not manually strip the debuginfo from the compiled binary files. Doing
> that breaks generation of the -debuginfo package.

This one confuses me a little - how is the file going to get stripped if I don't
do it manually? I have removed the strip for now but now rpmlint (rightfully in
my opinion) complains about unstripped binaries ..

> You should be consistent in using macros.

fixed

> *.a files, _if_ they they have to be packaged should be placed in a separated
libacpi-static

I don't think a -static package is needed here. I have removed the .a-File.

New SRPM: http://sven.lank.es/Fedora/SRPM/libacpi-0.2-5.fc9.src.rpm
SPEC: http://sven.lank.es/Fedora/SPECS/libacpi.spec


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.