[Bug 427824] Review Request: tmispell-voikko - An Ispell compatible front-end for spell-checking modules

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tmispell-voikko - An Ispell compatible front-end for spell-checking modules


https://bugzilla.redhat.com/show_bug.cgi?id=427824


ville.skytta at iki.fi changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review+              |fedora-review?




------- Additional Comments From ville.skytta at iki.fi  2008-05-11 16:19 EST -------
(In reply to comment #8)
> Could you
> please take another look at the new spec file to make sure everything is ok?

The enchant-voikko subpackage is missing a %defattr in %files.

When built with enchant support, does something that gets pulled in by library
dependencies own the %{_libdir}/enchant dir?

Are both the versioned and unversioned %{_libdir}/enchant/*.so* needed?

Also, if you like, things could be simplified a bit by replacing the toplevel
%define with "%bcond_with enchant", using %{with enchant} instead of
%{with_enchant}, and removing the %if around the enchant-voikko subpackage
definition (it's unnecessary).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.