[Bug 442233] Review Request: oprofileui - user interface for analysing oprofile data

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: oprofileui - user interface for analysing oprofile data


https://bugzilla.redhat.com/show_bug.cgi?id=442233


terjeros at phys.ntnu.no changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review+              |fedora-review?




------- Additional Comments From terjeros at phys.ntnu.no  2008-05-12 05:17 EST -------
Review Guidelines MUST items:
- [?] rpmlint output:
   oprofileui.x86_64: E: explicit-lib-dependency libglade2
   oprofileui.x86_64: E: explicit-lib-dependency libxml
 Can be ignored?

- [OK] package name
- [OK] %{name}.spec
- [OK] Packaging Guidelines
- [-] Licensing Guidelines
  Seems like GPLv2, not GPLv2+ to me.
  COPYING has 2+. however all files has GPLv2 only.

- [OK] License Field in spec
- [-] License text in %doc
  Ok, however not correct version.

- [OK] Spec file in en_US
- [OK] legible spec file
- [-] source matches upstream
 4ebd15796d44f2fd29ecd37c77021d41  oprofileui-0.2.0.tar.gz
 4ebd15796d44f2fd29ecd37c77021d41  oprofileui-0.2.0.tar.gz.1
  source is ok, however fix timestamp with e.g.
  wget -N http://labs.o-hand.com/sources/oprofileui/oprofileui-0.2.0.tar.gz

- [-] compiles successfully
- [-] BuildRequires
  Add desktop-file-utils to BuildRequires, now build stops with:
  /var/tmp/rpm-tmp.67346: line 32: desktop-file-install: command not found
  See: http://koji.fedoraproject.org/koji/taskinfo?taskID=604356

- N/A  %find_lang
- N/A  shared libs
- N/A  not relocatable
- [OK] directory ownership
- [OK] no duplicate files in %files
- [OK] proper permissions on files, %defattr present
- [OK] %clean section cleans %{buildroot}
- [-] consistently uses macros
  Change "$RPM_OPT_FLAGS" to %{optflags}

- [OK] package contains code
- N/A  large docs
- [OK] %doc files do not affect runtime behaviour
- N/A  header files in -devel
- N/A  static libs in -static
- N/A  foo.pc files
- N/A  libfoo.so.1.1
- N/A  no devel package
- N/A  no .la archives
- [OK]  desktop file
- [OK] Does not own files/dirs owned by other packages
- [OK] %install cleans out %{buildroot} first
- [OK] all filenames are valid ASCII and thus UTF-8
- [-] Scriptlets

  Add script to cache the shipped icons:
 
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-7103f6c38d1b5735e8477bdd569ad73ea2c49bda

Review Guidelines SHOULD items:
- [-]  license text, not correct, ping upstream?
- N/A  no translated descriptions available
- [-]  don't build in mock: 
    http://koji.fedoraproject.org/koji/taskinfo?taskID=604356
- [-]  build on all arch
- [OK] appears to work
- N/A  no scriptlets (yet)
- N/A  no sub-packages
- N/A  no foo.pc
- N/A  no file dependencies



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.