[Bug 446303] Review Request: perl-Text-Smart-Plugin - Template Toolkit plugin for Text::Smart

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Text-Smart-Plugin - Template Toolkit plugin for Text::Smart


https://bugzilla.redhat.com/show_bug.cgi?id=446303





------- Additional Comments From dlutter at redhat.com  2008-05-13 21:04 EST -------
Review

* General

  OK - Package name
  OK - License info is accurate
  OK - License tag is correct and licenses are approved
  OK - License files are installed as %doc
  OK - Specfile name
  OK - Specfile is legible
  OK - No prebuilt binaries included
  OK - BuildRoot value (one of the recommended values)
  OK - PreReq not used
  OK - Source md5sum matches upstream
  OK - No hardcoded pathnames
  OK - Package owns all the files it installs
  OK - 'Requires' create needed unowned directories
  OK - Package builds successfully on i386 and x86_64 (mock)
  OK - BuildRequires sufficient
  OK - File permissions set properly
  OK - Macro usage is consistent
  OK - rpmlint is silent

* Perl guidelines

  OK - Provide package name (generated)
  OK - Versioned MODULE_COMPAT_ requires
  OK - CPAN URL not versioned


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.