[Bug 226117] Merge Review: mailman
bugzilla at redhat.com
bugzilla at redhat.com
Fri May 16 16:48:14 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: mailman
https://bugzilla.redhat.com/show_bug.cgi?id=226117
bugzilla at redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Product|Fedora Extras |Fedora
Version|devel |rawhide
limb at jcomserv.net changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|nobody at fedoraproject.org |limb at jcomserv.net
Status|NEW |ASSIGNED
------- Additional Comments From limb at jcomserv.net 2008-05-16 12:48 EST -------
rpmlint on SRPM:
mailman.src:41: E: hardcoded-library-path in /usr/lib/%{name}
A library path is hardcoded to one of the following paths: /lib,
/usr/lib. It should be replaced by something like /%{_lib} or %{_libdir}.
FIX
mailman.src:135: E: configure-without-libdir-spec
A configure script is run without specifying the libdir. configure
options must be augmented with something like --libdir=%{_libdir}.
FIX
mailman.src: W: mixed-use-of-spaces-and-tabs (spaces: line 59, tab: line 121)
The specfile mixes use of spaces and tabs for indentation, which is a
cosmetic annoyance. Use either spaces or tabs for indentation, not both.
Minor, but FIX
mailman.src: W: strange-permission mailman-crontab-edit 0755
A file that you listed to include in your package has strange
permissions. Usually, a file should have 0644 permissions.
I don't see where this gets used. ???
mailman.src: W: strange-permission mailman-migrate-fhs 0755
A file that you listed to include in your package has strange
permissions. Usually, a file should have 0644 permissions.
This is installed at 0644. FIX.
On RPMS:
mailman.i386: E: non-standard-dir-perm /usr/lib/mailman/messages/et/LC_MESSAGES
02775
A standard directory should have permission set to 0755. If you get this
message, it means that you have wrong directory permissions in some dirs
included in your package.
This is for several languages.
mailman.i386: E: non-standard-dir-perm /usr/lib/mailman/templates/no 02775
A standard directory should have permission set to 0755. If you get this
message, it means that you have wrong directory permissions in some dirs
included in your package.
mailman.i386: E: non-executable-script /usr/lib/mailman/Mailman/Post.py 0644
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed. If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.
mailman.i386: E: wrong-script-interpreter
/usr/share/doc/mailman-2.1.10/contrib/mm-handler "/usr/local/bin/perl"
This script uses an incorrect interpreter.
mailman.i386: E: non-standard-dir-perm /var/lib/mailman/data 02775
A standard directory should have permission set to 0755. If you get this
message, it means that you have wrong directory permissions in some dirs
included in your package.
mailman.i386: E: wrong-script-interpreter
/usr/share/doc/mailman-2.1.10/contrib/qmail-to-mailman.py "@PYTHON@"
This script uses an incorrect interpreter.
mailman.i386: E: non-standard-dir-perm
/usr/lib/mailman/pythonlib/japanese/mappings 02775
A standard directory should have permission set to 0755. If you get this
message, it means that you have wrong directory permissions in some dirs
included in your package.
mailman.i386: W: file-not-utf8
/usr/share/doc/mailman-2.1.10/admin/doc/mailman-admin.txt
The character encoding of this file is not UTF-8. Consider converting it
in the specfile for example using iconv(1).
mailman.i386: E: zero-length
/usr/share/doc/mailman-2.1.10/admin/doc/mailman-admin/index.dat
mailman.i386: W: non-conffile-in-etc /etc/logrotate.d/mailman
A non-executable file in your package is being installed in /etc, but is not
a configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.
mailman.i386: E: zero-length
/usr/share/doc/mailman-2.1.10/admin/doc/mailman-member-es/index.dat
mailman.i386: E: setgid-binary /usr/lib/mailman/cgi-bin/rmlist mailman 02755
The file is setgid. Usually this is a packaging bug. If this is a game,
then, you should use the proper rpm group, or location.
mailman.i386: E: non-executable-script
/usr/lib/mailman/Mailman/Archiver/pipermail.py 0644
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed. If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.
mailman.i386: W: file-not-utf8
/usr/share/doc/mailman-2.1.10/admin/doc/mailman-member-es.txt
The character encoding of this file is not UTF-8. Consider converting it
in the specfile for example using iconv(1).
mailman.i386: E: setgid-binary /usr/lib/mailman/cgi-bin/roster mailman 02755
The file is setgid. Usually this is a packaging bug. If this is a game,
then, you should use the proper rpm group, or location.
mailman.i386: W: file-not-utf8 /usr/share/doc/mailman-2.1.10/ACKNOWLEDGMENTS
The character encoding of this file is not UTF-8. Consider converting it
in the specfile for example using iconv(1).
mailman.i386: E: setgid-binary /usr/lib/mailman/cgi-bin/listinfo mailman 02755
The file is setgid. Usually this is a packaging bug. If this is a game,
then, you should use the proper rpm group, or location.
mailman.i386: W: file-not-utf8 /usr/share/doc/mailman-2.1.10/README-I18N.en
The character encoding of this file is not UTF-8. Consider converting it
in the specfile for example using iconv(1).
mailman.i386: E: setgid-binary /usr/lib/mailman/cgi-bin/admindb mailman 02755
The file is setgid. Usually this is a packaging bug. If this is a game,
then, you should use the proper rpm group, or location.
mailman.i386: E: setgid-binary /usr/lib/mailman/mail/mailman mailman 02755
The file is setgid. Usually this is a packaging bug. If this is a game,
then, you should use the proper rpm group, or location.
mailman.i386: W: symlink-should-be-relative /etc/mailman/mm_cfg.py
/usr/lib/mailman/Mailman/mm_cfg.py
Absolute symlinks are problematic eg. when working with chroot environments.
mailman.i386: E: zero-length
/usr/share/doc/mailman-2.1.10/admin/doc/mailman-member/index.dat
mailman.i386: E: zero-length
/usr/share/doc/mailman-2.1.10/admin/doc/mailman-install/index.dat
mailman.i386: E: wrong-script-interpreter
/usr/share/doc/mailman-2.1.10/contrib/check_perms_grsecurity.py "@PYTHON@"
This script uses an incorrect interpreter.
mailman.i386: E: wrong-script-interpreter
/usr/share/doc/mailman-2.1.10/contrib/rotatelogs.py "@PYTHON@"
This script uses an incorrect interpreter.
mailman.i386: W: file-not-utf8
/usr/share/doc/mailman-2.1.10/admin/doc/mailman-member.txt
The character encoding of this file is not UTF-8. Consider converting it
in the specfile for example using iconv(1).
mailman.i386: E: setgid-binary /usr/lib/mailman/cgi-bin/private mailman 02755
The file is setgid. Usually this is a packaging bug. If this is a game,
then, you should use the proper rpm group, or location.
mailman.i386: E: setgid-binary /usr/lib/mailman/cgi-bin/create mailman 02755
The file is setgid. Usually this is a packaging bug. If this is a game,
then, you should use the proper rpm group, or location.
mailman.i386: E: setgid-binary /usr/lib/mailman/cgi-bin/admin mailman 02755
The file is setgid. Usually this is a packaging bug. If this is a game,
then, you should use the proper rpm group, or location.
mailman.i386: E: setgid-binary /usr/lib/mailman/cgi-bin/confirm mailman 02755
The file is setgid. Usually this is a packaging bug. If this is a game,
then, you should use the proper rpm group, or location.
I goes on like this for each file. There are scores of non-standard perm and
gid errors, but that's just because it's all owned by mailman, which is fine.
The above need to be addressed, for the most part. Full review forthcoming. . .
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list