[Bug 442871] Review Request: virt-top - Utility like top(1) for displaying virtualization stats
bugzilla at redhat.com
bugzilla at redhat.com
Mon May 19 19:20:20 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: virt-top - Utility like top(1) for displaying virtualization stats
https://bugzilla.redhat.com/show_bug.cgi?id=442871
tcallawa at redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
------- Additional Comments From tcallawa at redhat.com 2008-05-19 15:20 EST -------
Good:
- rpmlint checks return... nothing! :)
- package meets naming guidelines
- package meets packaging guidelines (general, ocaml)
- license (GPLv2+) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream (89eeae9afe0c86b262c7adf2d693110050de0f22)
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- locales ok
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the Fedora-package-review
mailing list