[Bug 447406] Review Request: libfakekey

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libfakekey


https://bugzilla.redhat.com/show_bug.cgi?id=447406





------- Additional Comments From mclasen at redhat.com  2008-05-19 21:44 EST -------
Builds fine in mock

rpmlint output:
libfakekey.i386: W: no-documentation
libfakekey.i386: W: one-line-command-in-%post /sbin/ldconfig
libfakekey.i386: W: one-line-command-in-%postun /sbin/ldconfig
libfakekey-devel.i386: W: no-documentation

You should include COPYING and ChangeLog as %doc files
and do as rpmlint wants you to:

%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig


package name: ok
spec file name: ok
packaging guidelines: ok
license: ok
license field: ok
license file: needs to include COPYING
spec language: ok
spec readability: ok
upstream sources: ok
builds: yes
ExcludeArch: n/a
BuildRequires: ok
locale handling: ok
ldconfig: see above
relocatable: n/a
directory ownership: ok
%file duplicates: ok
file permissions: ok
%clean: ok
macro use: ok
permissible content: ok
large docs: n/a
doc content: ok
headers: ok
static libs: n/a
pkgconfig files: ok
shared libs: ok
-devel package: ok
la files: ok
gui app: n/a
file ownership: ok
%install: ok
utf8 filenames: ok

summary: fix the two issues that rpmlint complained about, then it is fine.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.