[Bug 447429] Review Request: matchbox-keyboard

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: matchbox-keyboard


https://bugzilla.redhat.com/show_bug.cgi?id=447429





------- Additional Comments From mclasen at redhat.com  2008-05-19 23:09 EST -------
builds in mock after adding some missing BuildRequires:

libpng-devel, libXtst-devel

rpmlint output on the built packages:
rpmlint
/var/lib/mock/fedora-9-i386/result/matchbox-keyboard-0.1-0.2008.05.19.1.fc9.i386.rpm

matchbox-keyboard.i386: W: no-documentation
matchbox-keyboard.i386: W: one-line-command-in-%post update-desktop-database

for docs, should include ChangeLog, COPYING, AUTHORS, README

for the update-desktop-database usage, the recommended form is:

%post
update-desktop-database &> /dev/null ||:

%postun
update-desktop-database &> /dev/null ||:



package name: ok
spec file name: ok
packaging guidelines: ok, but 
  - should add a hint about where to get the svn snapshot
  - see the above comment about update-desktop-database
  - the explicit Requires for libfakekey is unnecessary
license: ok
license field: ok
license file: need to include COPYING
spec file language: ok
spec file legibility: ok
upstream sources: ok
buildable: ok
ExcludeArch: n/a
BuildRequires: need to add libpng-devel and libXtst-devel
locale handling: ok
ldconfig: ok
relocatable: n/a
directory ownership: ok
duplicate files: ok
file permissions: ok
%clean: ok
macro use: ok
permissible content: ok
large docs: n%d/a
%doc: ok
headers: n/a
static libs: n/a
pkgconfig files: n/a
shared libs: n/a
devel package: n/a
libtool archives: n/a
gui app: ok
directory ownership: ok
%install: ok
utf8 filenames: ok



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.