[Bug 447366] Review Request: python-virtkey

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-virtkey


https://bugzilla.redhat.com/show_bug.cgi?id=447366


mclasen at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |mclasen at redhat.com




------- Additional Comments From mclasen at redhat.com  2008-05-19 23:36 EST -------
Had to add a BuildRequires for libXtst-devel to make it build in mock

Warnings from rpmlint:

rpmlint /var/lib/mock/fedora-9-i386/result/python-virtkey-0.50-1.fc9.i386.rpm 
python-virtkey.i386: W: no-documentation
python-virtkey.i386: E: non-standard-executable-perm
/usr/lib/python2.5/site-packages/virtkey.so 0775

Nothing to do about the nonexisting docs, but the permissions should be fixed to
0755

package name: ok
spec file name: ok
packaging guidelines: ok, but
  - the explicit requires on gtk2 is unnecessary, and should be dropped 
license: ok
license field: ok
license file: ok
spec file language: ok
spec file legibility: ok
upstream source: ok
buildable: yes
ExcludeArch: n/a
BuildRequires; need to add libXtst-devel
locale handling: ok
ldconfig: n/a
relocatable: n/a
directory ownership: ok
duplicate files: ok
file permissions: see above
%clean: ok
macro use: ok
permissible content: ok
large docs: n/a
%doc content: ok
headers: n/a
static libs: n/a
pkgconfig files: n/a
shared libs: n/a
-devel package: n/a
libtool archives: ok
gui app: ok
%install: ok
utf8 filenames: ok






-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.