[Bug 225245] Merge Review: am-utils

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: am-utils


https://bugzilla.redhat.com/show_bug.cgi?id=225245





------- Additional Comments From kzak at redhat.com  2008-05-20 09:29 EST -------

(In reply to comment #1)
> rpmlint on SRPM:
> 
> am-utils.src:39: W: unversioned-explicit-obsoletes amd

 Removed, the "Obsolete" is legacy from very very old am-utils.

> am-utils.src:86: E: use-of-RPM_SOURCE_DIR
> am-utils.src:237: W: macro-in-%changelog pre
> am-utils.src:408: W: macro-in-%changelog pre 
> am-utils.src: W: mixed-use-of-spaces-and-tabs (spaces: line 33, tab: line 77)
> am-utils.src: W: summary-ended-with-dot Automount utilities including and

 Fixed.

> rpmlint on RPMS:
> 
> am-utils.i386: E: executable-marked-as-config-file /etc/rc.d/init.d/amd
> am-utils.i386: W: hidden-file-or-dir /.automount
> The file or directory is hidden. You should see if this is normal,
> and delete it from the package if not.
> 
> am-utils.i386: W: hidden-file-or-dir /.automount

 This is correct.

> am-utils.i386: E: non-readable /etc/amd.conf 0600 
> am-utils.i386: E: non-readable /etc/amd.net 0640

 This is correct.

> am-utils.i386: W: devel-file-in-non-devel-package /usr/lib/libamu.so

> Why is there not a -devel package?  I see that the spec removes other
> .so files, why not put them in -devel or delete this one?

We needn't a -devel package. The library is for only internal amd usage (some
amd commands share a code in this library).

 Fixed. We needn't the libamu.so symlink.

> am-utils.i386: W: incoherent-version-in-changelog 6.1.5-7 5:6.1.5-7.fc8
> am-utils.i386: W: obsolete-not-provided amd

 Fixed.

> am-utils.i386: W: conffile-without-noreplace-flag /etc/rc.d/init.d/amd

 Fixed.

> am-utils.i386: W: incoherent-init-script-name amd
> The init script name should be the same as the package name in lower case,
> or one with 'd' appended if it invokes a process by that name.
> 
> Would fixing this break anything?

 Sure. People assume "amd".

Now it seems better:

$ rpmlint am-utils-6.1.5-9.fc10.src.rpm 

$ rpmlint x86_64/am-utils-6.1.5-9.fc10.x86_64.rpm 
am-utils.x86_64: W: hidden-file-or-dir /.automount
am-utils.x86_64: W: hidden-file-or-dir /.automount
am-utils.x86_64: E: non-readable /etc/amd.conf 0600
am-utils.x86_64: E: non-readable /etc/amd.net 0640
am-utils.x86_64: W: dangerous-command-in-%pre mv
am-utils.x86_64: W: incoherent-init-script-name amd



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.