[Bug 435017] Review Request: SSM - coordinate superposition library

bugzilla at redhat.com bugzilla at redhat.com
Tue May 27 09:55:09 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: SSM - coordinate superposition library


https://bugzilla.redhat.com/show_bug.cgi?id=435017





------- Additional Comments From fenn at stanford.edu  2008-05-27 05:55 EST -------
MUSTFIX:
- Don't ship *.la's
Remove them in %install

done

SHOULD:
- %makeinstall is considered obsolete.
Better use "make DESTDIR=${RPM_BUILD_ROOT} install" if feasible.

done

CONSIDER:
- Feel strongly encouraged not to ship static libraries (consider adding
--disable-static to %configure)

Unfortunately, many scientific folk still use statically linked libs when
building execs, and like to have them available.

[Analogous comments also apply to further packages related to this package you
currently have pending for review]

done

new spec: http://www.stanford.edu/~fenn/packs/ssm.spec
new url: http://www.stanford.edu/~fenn/packs/ssm-0.1-4.f8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list